Talk:New code guidelines

From Mumble Wiki
Revision as of 16:25, 18 September 2013 by Kissaki0 (talk | contribs)
Jump to: navigation, search

<Kissaki> what are constants? Any var I declare const?

<Kissaki> I would add {} to if() return; as well

<Kissaki> removes a special

<Kissaki> and something may be added even to a return block

<Kissaki> I don't like the look of //!. It makes it look important, where it is just a normal comment.
instead ///

<Kissaki> I'd rather not "default: break;" in one line

<Kissaki> The constructor example code specifically shows why I would prefer opening braces in a new line. You can't easily distinguish where the head ends and the body block begins.

 Foo::Foo(int a, QObject *parent)
      : QObject(parent)
      , m_a(a) {
      doStuff();
  };